lkml.org 
[lkml]   [2018]   [Jul]   [17]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] x86: Avoid pr_cont() in show_opcodes()
    From
    Date
    On Wed, 2018-07-18 at 05:54 +0900, Tetsuo Handa wrote:
    > Corrected Signed-off-by: addresses.
    >
    > From 96d9d4d135994a081e54d33d23f5007c53d9b5dd Mon Sep 17 00:00:00 2001
    > From: Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>
    > Date: Tue, 17 Jul 2018 22:47:11 +0900
    > Subject: [PATCH v4] x86: Avoid pr_cont() in show_opcodes()
    >
    > Since syzbot is confused by concurrent printk() messages [1],
    > this patch changes show_opcodes() to use %*ph format string.
    >
    > When we start adding prefix to each line of printk() output,
    > we will be able to handle concurrent printk() messages.

    If this were applied via git am, the commit would include
    all the content from "Corrected Signed-off-by:"

    Perhaps it would be better to send this as a new patch without
    the leading 7 lines after the email header

    > diff --git a/arch/x86/kernel/dumpstack.c b/arch/x86/kernel/dumpstack.c
    []
    > @@ -93,26 +93,15 @@ static void printk_stack_address(unsigned long address, int reliable,
    > */
    > void show_opcodes(u8 *rip, const char *loglvl)
    > {
    > - unsigned int code_prologue = OPCODE_BUFSIZE * 2 / 3;
    > + const unsigned int prologue = OPCODE_BUFSIZE * 2 / 3;

    And this might be better as a #define to avoid
    a few more bytes of stack consumption.

    \
     
     \ /
      Last update: 2018-07-17 23:20    [W:4.173 / U:0.392 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site