Messages in this thread Patch in this message | | | From | Todd Poynor <> | Subject | [PATCH 20/32] staging: gasket: fix class create bug handling | Date | Tue, 17 Jul 2018 13:57:00 -0700 |
| |
From: Todd Poynor <toddpoynor@google.com>
class_create() never returns NULL, and this driver should never return PTR_ERR(NULL) anyway.
Reported-by: Dmitry Torokhov <dtor@chromium.org> Signed-off-by: Zhongze Hu <frankhu@chromium.org> Signed-off-by: Todd Poynor <toddpoynor@google.com> Reviewed-by: Dmitry Torokhov <dtor@chromium.org> --- drivers/staging/gasket/gasket_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/gasket/gasket_core.c b/drivers/staging/gasket/gasket_core.c index 0a87bc67eac19..b7f34576d4b3f 100644 --- a/drivers/staging/gasket/gasket_core.c +++ b/drivers/staging/gasket/gasket_core.c @@ -322,7 +322,7 @@ int gasket_register_device(const struct gasket_driver_desc *driver_desc) internal->class = class_create(driver_desc->module, driver_desc->name); - if (IS_ERR_OR_NULL(internal->class)) { + if (IS_ERR(internal->class)) { gasket_nodev_error("Cannot register %s class [ret=%ld]", driver_desc->name, PTR_ERR(internal->class)); ret = PTR_ERR(internal->class); -- 2.18.0.203.gfac676dfb9-goog
| |