lkml.org 
[lkml]   [2018]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH v3 7/9] dt-bindings: ata: ahci-platform: document port-supply
From


于 2018年7月16日 GMT+08:00 下午11:59:38, Rob Herring <robh@kernel.org> 写到:
>On Fri, Jul 13, 2018 at 11:03:04AM +0000, Corentin Labbe wrote:
>> This patch document the new optional port-supply
>>
>> Signed-off-by: Corentin Labbe <clabbe@baylibre.com>
>> ---
>> Documentation/devicetree/bindings/ata/ahci-platform.txt | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/ata/ahci-platform.txt
>b/Documentation/devicetree/bindings/ata/ahci-platform.txt
>> index 47652521a6ed..40a636b9851e 100644
>> --- a/Documentation/devicetree/bindings/ata/ahci-platform.txt
>> +++ b/Documentation/devicetree/bindings/ata/ahci-platform.txt
>> @@ -31,6 +31,7 @@ Optional properties:
>> - dma-coherent : Present if dma operations are coherent
>> - clocks : a list of phandle + clock specifier pairs
>> - target-supply : regulator for SATA target power
>> +- port-supply : regulator for SATA port
>
>Humm, I'm pretty sure that's what target-supply was supposed to be. If
>anything, need to clearly define what is what.
>
>How does this work with multiple ports?

He wrongly named it. It's for PHY.

>
>> - phys : reference to the SATA PHY node
>> - phy-names : must be "sata-phy"
>> - ahci-supply : regulator for AHCI controller
>
>Also, please group all the supplies together.
>
>> @@ -51,6 +52,7 @@ Sub-nodes required properties:
>> And at least one of the following properties:
>> - phys : reference to the SATA PHY node
>> - target-supply : regulator for SATA target power
>> +- port-supply : regulator for SATA port
>>
>> Examples:
>> sata@ffe08000 {
>> --
>> 2.16.4
>>
>
>_______________________________________________
>linux-arm-kernel mailing list
>linux-arm-kernel@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

\
 
 \ /
  Last update: 2018-07-16 18:03    [W:0.061 / U:0.300 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site