lkml.org 
[lkml]   [2018]   [Jul]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v5 3/6] crypto: Add Qcom prng driver
On 14-07-18, 12:16, Linus Walleij wrote:
> On Mon, Jul 9, 2018 at 8:20 AM Vinod Koul <vkoul@kernel.org> wrote:
>
> > This ports the Qcom prng from older hw_random driver.
> >
> > No change of functionality and move from hw_random to crypto
> > APIs is done.
> >
> > Signed-off-by: Vinod Koul <vkoul@kernel.org>
>
> FWIW:
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Thanks

> > +config CRYPTO_DEV_QCOM_RNG
> > + tristate "Qualcomm Randon Number Generator Driver"
>
> Random speling error.

Will fix, thanks for pointing

> > +#include <linux/of_device.h>
>
> Do you need this? It seems like a platform device fair and square.

It was required for of_device_get_match_data() but then the change is in
subsequent patch, I should move that

--
~Vinod

\
 
 \ /
  Last update: 2018-07-16 06:16    [W:0.058 / U:0.052 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site