Messages in this thread | | | Date | Mon, 16 Jul 2018 09:45:38 +0530 | From | Vinod <> | Subject | Re: [PATCH v5 3/6] crypto: Add Qcom prng driver |
| |
On 14-07-18, 12:16, Linus Walleij wrote: > On Mon, Jul 9, 2018 at 8:20 AM Vinod Koul <vkoul@kernel.org> wrote: > > > This ports the Qcom prng from older hw_random driver. > > > > No change of functionality and move from hw_random to crypto > > APIs is done. > > > > Signed-off-by: Vinod Koul <vkoul@kernel.org> > > FWIW: > Reviewed-by: Linus Walleij <linus.walleij@linaro.org>
Thanks
> > +config CRYPTO_DEV_QCOM_RNG > > + tristate "Qualcomm Randon Number Generator Driver" > > Random speling error.
Will fix, thanks for pointing
> > +#include <linux/of_device.h> > > Do you need this? It seems like a platform device fair and square.
It was required for of_device_get_match_data() but then the change is in subsequent patch, I should move that
-- ~Vinod
| |