| From | Dmitry Torokhov <> | Date | Sat, 14 Jul 2018 11:25:47 +0300 | Subject | Re: [PATCH 11/18] staging: gasket: always allow root open for write |
| |
On Sat, Jul 14, 2018 at 8:58 AM Todd Poynor <toddpoynor@gmail.com> wrote: > > From: Todd Poynor <toddpoynor@google.com> > > Always allow root to open device for writing. > > Drop special-casing of ioctl permissions for root vs. owner. > > Reported-by: Dmitry Torokhov <dtor@chromium.org> > Signed-off-by: Zhongze Hu <frankhu@chromium.org> > Signed-off-by: Todd Poynor <toddpoynor@google.com>
I think this patch is good as is, but as a followup you should create a patch that supports user namespaces, i.e. replaces capable(CAP_SYS_ADMIN) with ns_capable(...) in gasket_open() so you can allow containers to control the device, if necessary.
Reviewed-by: Dmitry Torokhov <dtor@chromium.org>
Thanks, Dmitry
|