Messages in this thread | | | From | (Eric W. Biederman) | Date | Sat, 14 Jul 2018 14:04:46 -0500 | Subject | Re: [PATCH] kconfig: remove EXPERT from CHECKPOINT_RESTORE |
| |
Kees Cook <keescook@chromium.org> writes:
> On Fri, Jul 13, 2018 at 1:55 PM, Andrew Morton > <akpm@linux-foundation.org> wrote: >> On Thu, 12 Jul 2018 11:33:33 -0500 ebiederm@xmission.com (Eric W. Biederman) wrote: >>> What is the value of disabling this functionality ever? >>> >>> Is there any reason why we don't just delete CONFIG_CHECKPOINT_RESTORE >>> entirely? >> >> For the vast number of Linux machines which aren't servers? Check out >> some defconfigs - only one of arm's 119 defconfigs selects it. > > Right, and I would bet the minification folks would like to keep it > out of their builds too. I think we should keep the config.
I take it then you are volunteering to test with and without the config option?
Even if the config option is kept I intend to rip it out every time I wind up touching code with it in. Config options have a real cost in testing and development.
For a config option that no one has come forward with an actual real world use case for disabling, that cost seems much too high.
Eric
| |