lkml.org 
[lkml]   [2018]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/6] mm/swapfile.c: Replace some #ifdef with IS_ENABLED()
On Fri, Jul 13, 2018 at 07:36:32AM +0800, Huang, Ying wrote:
> @@ -1260,7 +1257,6 @@ static void swapcache_free(swp_entry_t entry)
> }
> }
>
> -#ifdef CONFIG_THP_SWAP
> static void swapcache_free_cluster(swp_entry_t entry)
> {
> unsigned long offset = swp_offset(entry);
> @@ -1271,6 +1267,9 @@ static void swapcache_free_cluster(swp_entry_t entry)
> unsigned int i, free_entries = 0;
> unsigned char val;
>
> + if (!IS_ENABLED(CONFIG_THP_SWAP))
> + return;
> +

VM_WARN_ON_ONCE(1) here too?

The rest of the patch looks good.
\
 
 \ /
  Last update: 2018-07-15 22:07    [W:0.092 / U:0.780 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site