lkml.org 
[lkml]   [2018]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 2/2] pinctrl: berlin: add the as370 SoC pinctrl driver
Hi Jisheng,

I love your patch! Yet something to improve:

[auto build test ERROR on pinctrl/devel]
[also build test ERROR on v4.18-rc4 next-20180713]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url: https://github.com/0day-ci/linux/commits/Jisheng-Zhang/dt-binding-pinctrl-berlin-document-AS370-SoC-pinctrl/20180713-235943
base: https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git devel
config: x86_64-allmodconfig (attached as .config)
compiler: gcc-7 (Debian 7.3.0-16) 7.3.0
reproduce:
# save the attached .config to linux build tree
make ARCH=x86_64

All error/warnings (new ones prefixed by >>):

drivers/pinctrl/berlin/pinctrl-as370.c:330:1: sparse: 'MODULE_DEVICE_TABLE()' has implicit return type
>> drivers/pinctrl/berlin/pinctrl-as370.c:330:1: warning: data definition has no type or storage class
MODULE_DEVICE_TABLE(of, as370_pinctrl_match);
^~~~~~~~~~~~~~~~~~~
>> drivers/pinctrl/berlin/pinctrl-as370.c:330:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
>> drivers/pinctrl/berlin/pinctrl-as370.c:330:1: warning: parameter names (without types) in function declaration
cc1: some warnings being treated as errors

sparse warnings: (new ones prefixed by >>)

>> drivers/pinctrl/berlin/pinctrl-as370.c:330:1: sparse: 'MODULE_DEVICE_TABLE()' has implicit return type
drivers/pinctrl/berlin/pinctrl-as370.c:330:1: warning: data definition has no type or storage class
MODULE_DEVICE_TABLE(of, as370_pinctrl_match);
^~~~~~~~~~~~~~~~~~~
drivers/pinctrl/berlin/pinctrl-as370.c:330:1: error: type defaults to 'int' in declaration of 'MODULE_DEVICE_TABLE' [-Werror=implicit-int]
drivers/pinctrl/berlin/pinctrl-as370.c:330:1: warning: parameter names (without types) in function declaration
cc1: some warnings being treated as errors

vim +330 drivers/pinctrl/berlin/pinctrl-as370.c

322
323 static const struct of_device_id as370_pinctrl_match[] = {
324 {
325 .compatible = "syna,as370-soc-pinctrl",
326 .data = &as370_soc_pinctrl_data,
327 },
328 {}
329 };
> 330 MODULE_DEVICE_TABLE(of, as370_pinctrl_match);
331

---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[unhandled content-type:application/gzip]
\
 
 \ /
  Last update: 2018-07-15 22:07    [W:2.977 / U:0.044 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site