lkml.org 
[lkml]   [2018]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] [v2] bcache: stop using the deprecated get_seconds()
From
Date
On 2018/7/13 10:20 PM, Arnd Bergmann wrote:
> On Sat, Jun 23, 2018 at 10:12 AM, Coly Li <colyli@suse.de> wrote:
>> On 2018/6/22 9:48 PM, Arnd Bergmann wrote:
>>> The get_seconds function is deprecated now since it returns a 32-bit
>>> value that will eventually overflow, and we are replacing it throughout
>>> the kernel with ktime_get_seconds() or ktime_get_real_seconds() that
>>> return a time64_t.
>>>
>>> bcache uses get_seconds() to read the current system time and store it in
>>> the superblock as well as in uuid_entry structures that are user visible.
>>>
>>> Unfortunately, the two structures in are still limited to 32 bits, so this
>>> won't fix any real problems but will still overflow in year 2106. Let's
>>> at least document that properly, in case we get an updated format in the
>>> future it can be fixed. We still have a long time before the overflow
>>> and checking the tools at https://github.com/koverstreet/bcache-tools
>>> reveals no access to any of them.
>>>
>>> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
>>
>> Added to 4.19 for-next.
>
> I noticed this isn't part of linux-next (yet). Did it get dropped?
>
> Arnd
>
Hi Arnd,

It is here,
https://git.kernel.org/pub/scm/linux/kernel/git/colyli/bcache-patches.git/tree/for-next/0004-bcache-stop-using-the-deprecated-get_seconds.patch

It is for Linux v4.19, the merge window is not available yet, and I
don't post them to Jens yet.

Thanks.

Coly Li
\
 
 \ /
  Last update: 2018-07-15 22:06    [W:0.080 / U:0.004 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site