Messages in this thread | | | Date | Fri, 13 Jul 2018 12:50:10 +0100 | From | Mark Brown <> | Subject | Re: [PATCH 1/2] dt-bindings: pfuze100: add optional pfuze-disable-sw binding |
| |
On Fri, Jul 13, 2018 at 10:30:39AM +0200, Marco Felsch wrote: > On 18-07-12 16:31, Mark Brown wrote: > > On Thu, Jul 12, 2018 at 01:02:39PM +0200, Marco Felsch wrote:
> > > +Optional properties: > > > +- pfuze-disable-sw: Disable all unused switch regulators to save power
> > This is a bit of a confused way of specifying things that depends on the > > Linux implementation, and the property sounds like a double negative > > too. I'd say something like "pfuze-support-disable" and then explicitly > > say that this is a workaround for backwards compatibility.
> I can't find the double negative. Anyway your binding sounds better. So > I will use yours. Should we add a vendor prefix too to be clear? I will > also add some more informations to mark it as workaround.
The property doesn't disable the use of switch regulators, it enables their disabling. A vendor prefix is probably required but I can't entirely follow the DT rules there, it certainly shouldn't hurt anyway. [unhandled content-type:application/pgp-signature] | |