lkml.org 
[lkml]   [2018]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 02/13] staging:rtl8192u: remove typdef from enumeration HW90_BLOCK_E - Style
    Date
    Checkpatch warns about the creation of new types in code. This patch simply
    removes the typedef from the enumeration HW90_BLOCK_E to clear this
    warning. There should be no impact on run time code execution.

    Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
    ---
    drivers/staging/rtl8192u/r819xU_phy.c | 6 +++---
    drivers/staging/rtl8192u/r819xU_phy.h | 6 +++---
    2 files changed, 6 insertions(+), 6 deletions(-)

    diff --git a/drivers/staging/rtl8192u/r819xU_phy.c b/drivers/staging/rtl8192u/r819xU_phy.c
    index bc86e6bfb8f5..0462de662eff 100644
    --- a/drivers/staging/rtl8192u/r819xU_phy.c
    +++ b/drivers/staging/rtl8192u/r819xU_phy.c
    @@ -695,7 +695,7 @@ static void rtl8192_InitBBRFRegDef(struct net_device *dev)
    * return: return whether BB and RF is ok (0:OK, 1:Fail)
    * notice: This function may be removed in the ASIC
    ******************************************************************************/
    -u8 rtl8192_phy_checkBBAndRF(struct net_device *dev, HW90_BLOCK_E CheckBlock,
    +u8 rtl8192_phy_checkBBAndRF(struct net_device *dev, enum HW90_BLOCK_E CheckBlock,
    RF90_RADIO_PATH_E eRFPath)
    {
    u8 ret = 0;
    @@ -787,10 +787,10 @@ static void rtl8192_BB_Config_ParaFile(struct net_device *dev)

    /* ----Ckeck FPGAPHY0 and PHY1 board is OK---- */
    /* TODO: this function should be removed on ASIC */
    - for (eCheckItem = (HW90_BLOCK_E)HW90_BLOCK_PHY0;
    + for (eCheckItem = (enum HW90_BLOCK_E)HW90_BLOCK_PHY0;
    eCheckItem <= HW90_BLOCK_PHY1; eCheckItem++) {
    /* don't care RF path */
    - status = rtl8192_phy_checkBBAndRF(dev, (HW90_BLOCK_E)eCheckItem,
    + status = rtl8192_phy_checkBBAndRF(dev, (enum HW90_BLOCK_E)eCheckItem,
    (RF90_RADIO_PATH_E)0);
    if (status != 0) {
    RT_TRACE((COMP_ERR | COMP_PHY),
    diff --git a/drivers/staging/rtl8192u/r819xU_phy.h b/drivers/staging/rtl8192u/r819xU_phy.h
    index 4471a0e00936..0f680a04a468 100644
    --- a/drivers/staging/rtl8192u/r819xU_phy.h
    +++ b/drivers/staging/rtl8192u/r819xU_phy.h
    @@ -34,13 +34,13 @@ extern u32 rtl819XRadioB_Array[];
    extern u32 rtl819XRadioC_Array[];
    extern u32 rtl819XRadioD_Array[];

    -typedef enum _HW90_BLOCK {
    +enum HW90_BLOCK_E {
    HW90_BLOCK_MAC = 0,
    HW90_BLOCK_PHY0 = 1,
    HW90_BLOCK_PHY1 = 2,
    HW90_BLOCK_RF = 3,
    HW90_BLOCK_MAXIMUM = 4, /* Never use this */
    -} HW90_BLOCK_E, *PHW90_BLOCK_E;
    +};

    typedef enum _RF90_RADIO_PATH {
    RF90_PATH_A = 0, /* Radio Path A */
    @@ -69,7 +69,7 @@ u32 rtl8192_phy_QueryRFReg(struct net_device *dev, RF90_RADIO_PATH_E eRFPath,
    void rtl8192_phy_configmac(struct net_device *dev);
    void rtl8192_phyConfigBB(struct net_device *dev, u8 ConfigType);
    u8 rtl8192_phy_checkBBAndRF(struct net_device *dev,
    - HW90_BLOCK_E CheckBlock, RF90_RADIO_PATH_E eRFPath);
    + enum HW90_BLOCK_E CheckBlock, RF90_RADIO_PATH_E eRFPath);
    void rtl8192_BBConfig(struct net_device *dev);
    void rtl8192_phy_getTxPower(struct net_device *dev);
    void rtl8192_phy_setTxPower(struct net_device *dev, u8 channel);
    --
    2.18.0
    \
     
     \ /
      Last update: 2018-07-15 22:06    [W:5.267 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site