lkml.org 
[lkml]   [2018]   [Jul]   [13]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] DAC960: hide unused procfs helpers
From
Date
Pls ignore this, there has a fix.

[PATCH] block/DAC960.c: fix defined but not used build warnings

On 2018/7/13 15:16, YueHaibing wrote:
> When CONFIG_PROC_FS isn't set, gcc warning this:
>
> drivers/block/DAC960.c:6429:12: warning: ‘dac960_proc_show’ defined but not used [-Wunused-function]
> static int dac960_proc_show(struct seq_file *m, void *v)
> ^
> drivers/block/DAC960.c:6449:12: warning: ‘dac960_initial_status_proc_show’ defined but not used [-Wunused-function]
> static int dac960_initial_status_proc_show(struct seq_file *m, void *v)
> ^
> drivers/block/DAC960.c:6456:12: warning: ‘dac960_current_status_proc_show’ defined but not used [-Wunused-function]
> static int dac960_current_status_proc_show(struct seq_file *m, void *v)
> ^
> fix this by adding #ifdef around them.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
> drivers/block/DAC960.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/block/DAC960.c b/drivers/block/DAC960.c
> index f651806..7a05831 100644
> --- a/drivers/block/DAC960.c
> +++ b/drivers/block/DAC960.c
> @@ -6426,6 +6426,7 @@ static bool DAC960_V2_ExecuteUserCommand(DAC960_Controller_T *Controller,
> return true;
> }
>
> +#ifdef CONFIG_PROC_FS
> static int dac960_proc_show(struct seq_file *m, void *v)
> {
> unsigned char *StatusMessage = "OK\n";
> @@ -6485,6 +6486,7 @@ static int dac960_current_status_proc_show(struct seq_file *m, void *v)
> seq_printf(m, "%.*s", Controller->CurrentStatusLength, Controller->CurrentStatusBuffer);
> return 0;
> }
> +#endif
>
> static int dac960_user_command_proc_show(struct seq_file *m, void *v)
> {
>

\
 
 \ /
  Last update: 2018-07-15 22:06    [W:0.068 / U:0.340 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site