| Subject | Re: [PATCH 02/39] x86/entry/32: Rename TSS_sysenter_sp0 to TSS_entry_stack | From | Andy Lutomirski <> | Date | Thu, 12 Jul 2018 13:44:07 -0700 |
| |
> On Jul 11, 2018, at 4:29 AM, Joerg Roedel <joro@8bytes.org> wrote: > > From: Joerg Roedel <jroedel@suse.de> > > The stack address doesn't need to be stored in tss.sp0 if > we switch manually like on sysenter. Rename the offset so > that it still makes sense when we change its location. > > We will also use this stack for all kernel-entry points, not > just sysenter. Reflect that in the name as well.
Reviewed-by: Andy Lutomirski <luto@kernel.org>
But, if there’s another version, please fix this comment:
> > > > /* Offset from the sysenter stack to tss.sp0 */
Here
> - DEFINE(TSS_sysenter_sp0, offsetof(struct cpu_entry_area, tss.x86_tss.sp0) - > + DEFINE(TSS_entry_stack, offsetof(struct cpu_entry_area, tss.x86_tss.sp0) - > offsetofend(struct cpu_entry_area, entry_stack_page.stack)); > > #ifdef CONFIG_STACKPROTECTOR > -- > 2.7.4 >
|