lkml.org 
[lkml]   [2018]   [Jul]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2 3/6] 9p: Replace the fidlist with an IDR
Matthew Wilcox wrote on Thu, Jul 12, 2018:
> > Ah, I had missed that you didn't update this memset as you said in reply
> > to comment on v1.
>
> Rather than update the memset, I ...
>
> > Could you resend just this patch and either initialize fid->fid or use
> > kzalloc for the fid allocation?
> >
> > > + fid->fid = 0;
>
> Did that instead ;-)
>
> If I were going to initialise the entire structure to 0, I'd replace
> the kmalloc with kzalloc and drop the memset altogether.

Oh, I'm blind, sorry! :)

> > If you do resend, alignment here was wrong.
>
> I think this warning from checkpatch is complete bullshit. It's
> really none of checkpatch's business how I choose to align function
> arguments.
>
> That said, if you want it to be aligned some particular way, feel free
> to adjust the whitespace. I don't care.

I would tend to agree that sometimes checkpatch is overzealous, but
having worked on projects where code style is all over the place it
really feels much more comfortable to have a consistent style
everywhere.

Thanks for the permission, I'll adjust it (assuming this does end up
getting pulled from my branch, but nobody yelled so far)

--
Dominique Martinet
\
 
 \ /
  Last update: 2018-07-15 22:05    [W:0.082 / U:1.240 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site