lkml.org 
[lkml]   [2018]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v11 5/8] i2c: fsi: Add transfer implementation

> > > + cmd |= FIELD_PREP(I2C_CMD_ADDR, msg->addr >> 1);
> > I just noticed this and wonder: Don't you need the LSB of the address?
> > It is not the RW flag, this is encoded in msg->flags.
>
> So, the hardware interprets the LSB as the RW flag. It wouldn't be possible
> to have a device addressed with the LSB set on this I2C master.

But msg->addr is 7 bit and LSB aligned. If I am not horribly wrong, with
the above code, an EEPROM at 0x50 would show up as 0x28 with your
driver?

> Indeed, real 10-bit addresses require some additional manipulation of this
> I2C master in order to work. We don't support it right now.

Then you should remove the associated FUNC flag.

[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2018-07-10 20:51    [W:0.097 / U:0.472 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site