Messages in this thread |  | | Date | Tue, 10 Jul 2018 08:29:07 +0200 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH v2 3/7] mhi_bus: core: add support for data transfer |
| |
On Mon, Jul 09, 2018 at 01:08:10PM -0700, Sujeev Dias wrote: > +static void mhi_add_ring_element(struct mhi_controller *mhi_cntrl, > + struct mhi_ring *ring) > +{ > + ring->wp += ring->el_size; > + if (ring->wp >= (ring->base + ring->len)) > + ring->wp = ring->base; > + /* smp update */ > + smp_wmb();
Why do this? You need to comment the heck out of odd stuff like this.
Also, why are you using your own ring buffer code? What's wrong with the code that is in the kernel already for this type of thing?
thanks,
greg k-h
|  |