lkml.org 
[lkml]   [2018]   [Jul]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH 01/14] thermal: ti-soc-thermal: fix TALERT IRQ handling for DRA752
From
Date


On 5/14/2018 5:12 PM, Bartlomiej Zolnierkiewicz wrote:
> .report_temperature is not set in dra752_data which
> results in temperature updates not being propagated by
> ti_bandgap_talert_irq_handler() (it doesn't make much
> sense to handle TALERT IRQ without reporting temperature
> updates to the thermal core). Fix it.

ATM no one is using TALERT as the thermal software polls on the
temperature. No real benefit from TALERT.

TALERT is set at different temperature and software polling thresholds
come from Device tree and i believe its best for software to go by
polling and then act on trip points.

>
> Signed-off-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> ---
> drivers/thermal/ti-soc-thermal/dra752-thermal-data.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/thermal/ti-soc-thermal/dra752-thermal-data.c b/drivers/thermal/ti-soc-thermal/dra752-thermal-data.c
> index 33a3030..e8ab7e5 100644
> --- a/drivers/thermal/ti-soc-thermal/dra752-thermal-data.c
> +++ b/drivers/thermal/ti-soc-thermal/dra752-thermal-data.c
> @@ -338,6 +338,7 @@
> .adc_end_val = DRA752_ADC_END_VALUE,
> .expose_sensor = ti_thermal_expose_sensor,
> .remove_sensor = ti_thermal_remove_sensor,
> + .report_temperature = ti_thermal_report_sensor_temperature,
> .sensors = {
> {
> .registers = &dra752_mpu_temp_sensor_registers,
>

\
 
 \ /
  Last update: 2018-07-11 04:20    [W:0.166 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site