Messages in this thread | | | From | Linus Torvalds <> | Date | Tue, 10 Jul 2018 16:55:37 -0700 | Subject | Re: [PATCH 1/2] drivers: core: Don't try to use a dead glue_dir |
| |
On Tue, Jul 10, 2018 at 4:32 PM Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote: > > > I like that fix, which should make this patch obsolete, right? > > Yes, for that specific issue, but Linus seemed to think patch 1 was the > "right thing to do" regardless...
I would definitely prefer either a kobject_get_unless_zero() or a warning if it is ever zero.
The fact that right now it silently can do known bad things, and then causes odd corruption _later_, is not good.
Linus
| |