Messages in this thread | | | From | Masahiro Yamada <> | Date | Sat, 9 Jun 2018 20:36:56 +0900 | Subject | Re: [PATCH] kbuild: fix endless syncconfig in case arch Makefile sets CROSS_COMPILE |
| |
2018-06-08 17:20 GMT+09:00 Geert Uytterhoeven <geert@linux-m68k.org>: > Hi Yamada-san, > > On Fri, Jun 8, 2018 at 2:21 AM, Masahiro Yamada > <yamada.masahiro@socionext.com> wrote: >> Commit 21c54b774744 ("kconfig: show compiler version text in the top >> comment") was intended to detect the compiler upgrade, but Geert >> reported a breakage on the m68k build. >> >> The compiler upgrade is detected by the change of the environment >> variable, CC_VERSION_TEXT, which contains the first line of the output >> from $(CC) --version. Currently, this works well when CROSS_COMPILE >> is given via the environment variable or the Make command line. >> >> However, some architectures such as m68k can specify CROSS_COMPILE >> from arch/$(SRCARCH)/Makefile as well. In this case, "make ARCH=m68k" >> ends up with endless syncconfig loop. >> >> $ make ARCH=m68k defconfig >> *** Default configuration is based on 'multi_defconfig' >> # >> # configuration written to .config >> # >> $ make ARCH=m68k >> scripts/kconfig/conf --syncconfig Kconfig >> scripts/kconfig/conf --syncconfig Kconfig >> scripts/kconfig/conf --syncconfig Kconfig >> scripts/kconfig/conf --syncconfig Kconfig > > [...] > >> Fixes: 21c54b774744 ("kconfig: show compiler version text in the top comment") >> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org> >> Signed-off-by: Masahiro Yamada <yamada.masahiro@socionext.com> > > Thanks for fixing this quickly! > > Tested-by: Geert Uytterhoeven <geert@linux-m68k.org>
Applied to linux-kbuild.
-- Best Regards Masahiro Yamada
| |