lkml.org 
[lkml]   [2018]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.17 02/15] bnx2x: use the right constant
    Date
    4.17-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Julia Lawall <Julia.Lawall@lip6.fr>

    [ Upstream commit dd612f18a49b63af8b3a5f572d999bdb197385bc ]

    Nearby code that also tests port suggests that the P0 constant should be
    used when port is zero.

    The semantic match that finds this problem is as follows:
    (http://coccinelle.lip6.fr/)

    // <smpl>
    @@
    expression e,e1;
    @@

    * e ? e1 : e1
    // </smpl>

    Fixes: 6c3218c6f7e5 ("bnx2x: Adjust ETS to 578xx")
    Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
    +++ b/drivers/net/ethernet/broadcom/bnx2x/bnx2x_link.c
    @@ -588,7 +588,7 @@ static void bnx2x_ets_e3b0_nig_disabled(
    * slots for the highest priority.
    */
    REG_WR(bp, (port) ? NIG_REG_P1_TX_ARB_NUM_STRICT_ARB_SLOTS :
    - NIG_REG_P1_TX_ARB_NUM_STRICT_ARB_SLOTS, 0x100);
    + NIG_REG_P0_TX_ARB_NUM_STRICT_ARB_SLOTS, 0x100);
    /* Mapping between the CREDIT_WEIGHT registers and actual client
    * numbers
    */

    \
     
     \ /
      Last update: 2018-06-09 17:54    [W:4.076 / U:0.328 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site