lkml.org 
[lkml]   [2018]   [Jun]   [9]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 4.16 43/48] net : sched: cls_api: deal with egdev path only if needed
    Date
    4.16-stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Or Gerlitz <ogerlitz@mellanox.com>

    [ Upstream commit f8f4bef322e4600c5856911c7a632c0e3da920d6 ]

    When dealing with ingress rule on a netdev, if we did fine through the
    conventional path, there's no need to continue into the egdev route,
    and we can stop right there.

    Not doing so may cause a 2nd rule to be added by the cls api layer
    with the ingress being the egdev.

    For example, under sriov switchdev scheme, a user rule of VFR A --> VFR B
    will end up with two HW rules (1) VF A --> VF B and (2) uplink --> VF B

    Fixes: 208c0f4b5237 ('net: sched: use tc_setup_cb_call to call per-block callbacks')
    Signed-off-by: Or Gerlitz <ogerlitz@mellanox.com>
    Signed-off-by: David S. Miller <davem@davemloft.net>
    Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
    ---
    net/sched/cls_api.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/net/sched/cls_api.c
    +++ b/net/sched/cls_api.c
    @@ -1587,7 +1587,7 @@ int tc_setup_cb_call(struct tcf_block *b
    return ret;
    ok_count = ret;

    - if (!exts)
    + if (!exts || ok_count)
    return ok_count;
    ret = tc_exts_setup_cb_egdev_call(exts, type, type_data, err_stop);
    if (ret < 0)

    \
     
     \ /
      Last update: 2018-06-09 17:45    [W:4.418 / U:0.024 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site