lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 3/3] net: phy: xgmiitorgmii: Check read_status results
    Date
    We're ignoring the result of the attached phy device's read_status().
    Return it so we can detect errors.

    Signed-off-by: Brandon Maier <brandon.maier@rockwellcollins.com>
    ---
    drivers/net/phy/xilinx_gmii2rgmii.c | 5 ++++-
    1 file changed, 4 insertions(+), 1 deletion(-)

    diff --git a/drivers/net/phy/xilinx_gmii2rgmii.c b/drivers/net/phy/xilinx_gmii2rgmii.c
    index d6f8b64cddbe..74a8782313cf 100644
    --- a/drivers/net/phy/xilinx_gmii2rgmii.c
    +++ b/drivers/net/phy/xilinx_gmii2rgmii.c
    @@ -42,8 +42,11 @@ static int xgmiitorgmii_read_status(struct phy_device *phydev)
    struct mii_bus *bus = priv->mdio->bus;
    int addr = priv->mdio->addr;
    u16 val = 0;
    + int err;

    - priv->phy_drv->read_status(phydev);
    + err = priv->phy_drv->read_status(phydev);
    + if (err < 0)
    + return err;

    val = mdiobus_read(bus, addr, XILINX_GMII2RGMII_REG);
    val &= ~XILINX_GMII2RGMII_SPEED_MASK;
    --
    2.14.3
    \
     
     \ /
      Last update: 2018-06-07 18:08    [W:3.487 / U:0.008 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site