lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 100/410] scsi: libsas: fix error when getting phy events
    3.16.57-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Jason Yan <yanaijie@huawei.com>

    commit 2b23d9509fd7174b362482cf5f3b5f9a2265bc33 upstream.

    The intend purpose here was to goto out if smp_execute_task() returned
    error. Obviously something got screwed up. We will never get these link
    error statistics below:

    ~:/sys/class/sas_phy/phy-1:0:12 # cat invalid_dword_count
    0
    ~:/sys/class/sas_phy/phy-1:0:12 # cat running_disparity_error_count
    0
    ~:/sys/class/sas_phy/phy-1:0:12 # cat loss_of_dword_sync_count
    0
    ~:/sys/class/sas_phy/phy-1:0:12 # cat phy_reset_problem_count
    0

    Obviously we should goto error handler if smp_execute_task() returns
    non-zero.

    Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver")
    Signed-off-by: Jason Yan <yanaijie@huawei.com>
    CC: John Garry <john.garry@huawei.com>
    CC: chenqilin <chenqilin2@huawei.com>
    CC: chenxiang <chenxiang66@hisilicon.com>
    Reviewed-by: Hannes Reinecke <hare@suse.com>
    Reviewed-by: Christoph Hellwig <hch@lst.de>
    Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/scsi/libsas/sas_expander.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/scsi/libsas/sas_expander.c
    +++ b/drivers/scsi/libsas/sas_expander.c
    @@ -675,7 +675,7 @@ int sas_smp_get_phy_events(struct sas_ph
    res = smp_execute_task(dev, req, RPEL_REQ_SIZE,
    resp, RPEL_RESP_SIZE);

    - if (!res)
    + if (res)
    goto out;

    phy->invalid_dword_count = scsi_to_u32(&resp[12]);
    \
     
     \ /
      Last update: 2018-06-07 18:07    [W:4.072 / U:0.160 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site