lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 334/410] x86/spectre_v2: Don't check microcode versions when running under hypervisors
    3.16.57-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>

    commit 36268223c1e9981d6cfc33aff8520b3bde4b8114 upstream.

    As:

    1) It's known that hypervisors lie about the environment anyhow (host
    mismatch)

    2) Even if the hypervisor (Xen, KVM, VMWare, etc) provided a valid
    "correct" value, it all gets to be very murky when migration happens
    (do you provide the "new" microcode of the machine?).

    And in reality the cloud vendors are the ones that should make sure that
    the microcode that is running is correct and we should just sing lalalala
    and trust them.

    Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
    Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
    Reviewed-by: Paolo Bonzini <pbonzini@redhat.com>
    Cc: Wanpeng Li <kernellwp@gmail.com>
    Cc: kvm <kvm@vger.kernel.org>
    Cc: Krčmář <rkrcmar@redhat.com>
    Cc: Borislav Petkov <bp@alien8.de>
    CC: "H. Peter Anvin" <hpa@zytor.com>
    Link: https://lkml.kernel.org/r/20180226213019.GE9497@char.us.oracle.com
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    arch/x86/kernel/cpu/intel.c | 7 +++++++
    1 file changed, 7 insertions(+)

    --- a/arch/x86/kernel/cpu/intel.c
    +++ b/arch/x86/kernel/cpu/intel.c
    @@ -68,6 +68,13 @@ static bool bad_spectre_microcode(struct
    {
    int i;

    + /*
    + * We know that the hypervisor lie to us on the microcode version so
    + * we may as well hope that it is running the correct version.
    + */
    + if (cpu_has(c, X86_FEATURE_HYPERVISOR))
    + return false;
    +
    for (i = 0; i < ARRAY_SIZE(spectre_bad_microcodes); i++) {
    if (c->x86_model == spectre_bad_microcodes[i].model &&
    c->x86_mask == spectre_bad_microcodes[i].stepping)
    \
     
     \ /
      Last update: 2018-06-07 17:52    [W:5.242 / U:0.708 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site