lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Date
    Subject[PATCH 3.16 071/410] power: supply: ab8500_charger: Fix an error handling path
    3.16.57-rc1 review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>

    commit bf59fddde1c3eab89eb8dca8f3d3dc097887d2bb upstream.

    'ret' is know to be 0 at this point, because it has not been updated by the
    the previous call to 'abx500_mask_and_set_register_interruptible()'.

    Fix it by updating 'ret' before checking if an error occurred.

    Fixes: 84edbeeab67c ("ab8500-charger: AB8500 charger driver")
    Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
    Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>
    [bwh: Backported to 3.16: adjust filename]
    Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
    ---
    drivers/power/ab8500_charger.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    --- a/drivers/power/ab8500_charger.c
    +++ b/drivers/power/ab8500_charger.c
    @@ -3224,7 +3224,7 @@ static int ab8500_charger_init_hw_regist
    }

    /* Enable backup battery charging */
    - abx500_mask_and_set_register_interruptible(di->dev,
    + ret = abx500_mask_and_set_register_interruptible(di->dev,
    AB8500_RTC, AB8500_RTC_CTRL_REG,
    RTC_BUP_CH_ENA, RTC_BUP_CH_ENA);
    if (ret < 0)
    \
     
     \ /
      Last update: 2018-06-07 17:15    [W:3.441 / U:0.012 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site