Messages in this thread | | | Subject | Re: [PATCH] md: Unify mddev destruction paths | From | Jens Axboe <> | Date | Thu, 7 Jun 2018 19:36:27 -0600 |
| |
On 6/7/18 6:52 PM, Kent Overstreet wrote: > Previously, mddev_put() had a couple different paths for freeing a > mddev, due to the fact that the kobject wasn't initialized when the > mddev was first allocated. If we move the kobject_init() to when it's > first allocated and just use kobject_add() later, we can clean all this > up. > > This also removes a hack in mddev_put() to avoid freeing biosets under a > spinlock, which involved copying biosets on the stack after the reset > bioset_init() changes.
Looks good to me, much nicer than the previous hack.
-- Jens Axboe
| |