lkml.org 
[lkml]   [2018]   [Jun]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] md: Unify mddev destruction paths
From
Date
On 6/7/18 6:52 PM, Kent Overstreet wrote:
> Previously, mddev_put() had a couple different paths for freeing a
> mddev, due to the fact that the kobject wasn't initialized when the
> mddev was first allocated. If we move the kobject_init() to when it's
> first allocated and just use kobject_add() later, we can clean all this
> up.
>
> This also removes a hack in mddev_put() to avoid freeing biosets under a
> spinlock, which involved copying biosets on the stack after the reset
> bioset_init() changes.

Looks good to me, much nicer than the previous hack.

--
Jens Axboe

\
 
 \ /
  Last update: 2018-06-08 03:36    [W:0.028 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site