Messages in this thread | | | Date | Wed, 06 Jun 2018 13:48:36 -0400 (EDT) | Subject | Re: [PATCH 1/1] net: dsa: b53: Fix for brcm tag issue in Cygnus SoC | From | David Miller <> |
| |
From: Florian Fainelli <f.fainelli@gmail.com> Date: Tue, 5 Jun 2018 14:41:41 -0700
> On 06/05/2018 01:38 PM, Arun Parameswaran wrote: >> In the Broadcom Cygnus SoC, the brcm tag needs to be inserted >> in between the mac address and the ether type (should use >> 'DSA_PROTO_TAG_BRCM') for the packets sent to the internal >> b53 switch. >> >> Since the Cygnus was added with the BCM58XX device id and the >> BCM58XX uses 'DSA_PROTO_TAG_BRCM_PREPEND', the data path is >> broken, due to the incorrect brcm tag location. >> >> Add a new b53 device id (BCM583XX) for Cygnus family to fix the >> issue. Add the new device id to the BCM58XX family as Cygnus >> is similar to the BCM58XX in most other functionalities. >> >> Fixes: 11606039604c ("net: dsa: b53: Support prepended Broadcom tags") >> >> Signed-off-by: Arun Parameswaran <arun.parameswaran@broadcom.com> > > Clement originally reported this to me/us: > > Reported-by: Clément Péron <peron.clem@gmail.com> > > I completely overlooked that when adding support for prepended Broadcom > tags, thanks for the fix Arun! > > Reviewed-by: Florian Fainelli <f.fainelli@gmail.com> > > David, can you also queue this up for -stable? Thank you
Applied and queued up for -stable, thanks everyone.
| |