Messages in this thread | | | Date | Mon, 4 Jun 2018 17:31:41 -0400 | From | Steven Rostedt <> | Subject | Re: [PATCH 1/4 v2] NFS: slight optimization for walking list for delegations |
| |
On Thu, 31 May 2018 15:23:22 +1000 NeilBrown <neilb@suse.com> wrote:
> There are 3 places where we walk the list of delegations > for an nfs_client. > In each case there are two nested loops, one for nfs_servers > and one for nfs_delegations. > > When we find an interesting delegation we try to get an active > reference to the server. If that fails, it is pointless to > continue to look at the other delegation for the server as > we will never be able to get an active reference. > So instead of continuing in the inner loop, break out > and continue in the outer loop. > > Signed-off-by: NeilBrown <neilb@suse.com> > --- > > This time with a Signed-off-by - sorry. > I took the opportunity to follow Steven's suggestion > of adding a comment to the new 'break' statements. >
Acked-by: Steven Rostedt (VMware) <rostedt@goodmis.org>
-- Steve
| |