lkml.org 
[lkml]   [2018]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 2/9] x86: objtool: use asm macro for better compiler decisions
    On Mon, Jun 04, 2018 at 04:21:24AM -0700, Nadav Amit wrote:
    > +#ifdef CONFIG_STACK_VALIDATION
    > +.macro ANNOTATE_UNREACHABLE counter:req
    > +\counter:
    > + .pushsection .discard.unreachable
    > + .long \counter\()b -.
    > + .popsection
    > +.endm
    > +
    > +.macro ANNOTATE_REACHABLE counter:req
    > +\counter:
    > + .pushsection .discard.reachable
    > + .long \counter\()b -.
    > + .popsection
    > +.endm
    > +
    > +.macro ASM_UNREACHABLE
    > +999:
    > + .pushsection .discard.unreachable
    > + .long 999b - .
    > + .popsection
    > +.endm
    > +#else /* CONFIG_STACK_VALIDATION */
    > +.macro ANNOTATE_UNREACHABLE counter:req
    > +.endm
    > +
    > +.macro ANNOTATE_UNREACHABLE counter:req
    > +.endm
    > +
    > +.macro ASM_UNREACHABLE
    > +.endm /* CONFIG_STACK_VALIDATION */
    > +#endif

    The '/* CONFIG_STACK_VALIDATION */' comment is on the wrong line.

    Otherwise:

    Reviewed-by: Josh Poimboeuf <jpoimboe@redhat.com>

    --
    Josh

    \
     
     \ /
      Last update: 2018-06-04 21:04    [W:4.079 / U:0.676 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site