Messages in this thread | | | Date | Mon, 4 Jun 2018 06:18:12 +0200 | From | Samuel Ortiz <> | Subject | Re: [PATCH] NFC: fdp: fix signed less or equal zero check in u8 max_size |
| |
Hi Colin,
On Tue, Jan 30, 2018 at 03:33:59PM +0000, Colin King wrote: > From: Colin Ian King <colin.king@canonical.com> > > The u8 variable max_size is being assigned a return value from the > call to nci_conn_max_data_pkt_payload_size that can return a -ve > error return. Since max_size is a u8, the -ve check for the error will > always be false. Fix this by making max_size an int type. > > Detected using Coccinelle: > drivers/nfc/fdp/fdp.c:208:5-13: WARNING: Unsigned expression compared > with zero: max_size <= 0 > > Fixes: a06347c04c13 ("NFC: Add Intel Fields Peak NFC solution driver") > Signed-off-by: Colin Ian King <colin.king@canonical.com> > --- > drivers/nfc/fdp/fdp.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Applied to nfc-next, thanks.
Cheers, Samuel.
| |