lkml.org 
[lkml]   [2018]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v8 0/2] SDM845 System Cache Driver
On 2018-05-23 17:35, Rishabh Bhatnagar wrote:
> This series implements system cache or LLCC(Last Level Cache
> Controller)
> driver for SDM845 SOC. The purpose of the driver is to partition the
> system cache and program the settings such as priortiy, lines to probe
> while doing a look up in the system cache, low power related settings
> etc.
> The partitions are called cache slices. Each cache slice is associated
> with size and SCID(System Cache ID). The driver also provides API for
> clients to query the cache slice details,activate and deactivate them.
>
> The driver can be broadly classified into:
> * SOC specific driver: llcc-sdm845.c: Cache partitioning and cache
> slice
> properties for usecases on sdm845 that need to use system cache.
>
> * API : llcc-slice.c: Exports APIs to clients to query cache slice
> details,
> activate and deactivate cache slices.
>
> Changes since v7:
> * Change the DT node name to cache-controller.
> * Use the module_platform_driver_macro
> * Use GENMASK and SZ_* macros
> * Correct indentation, and remove unnecessary assignemnts.
> * Addresed all comments by Andy Schevchenko except the comment to
> ignore some
> lines of code going over 80 characters.
>
> Changes since v6:
> * Remove the max-slices property from DT.
> * Make client's slice_ids as macros.
> * Unlock mutex while returning from function in case of error.
>
> Changes since v5:
> * Remove client information from DT.
> * Make the llcc driver data as global.
> * Check return value of llcc_update_act_ctrl function
> * Change error returned from -EFAULT to -EINVAL
>
> Changes since v4:
> * Remove null pointer checks as per comments.
> * Remove extra blank lines.
>
> Changes since v3:
> * Use the regmap_read_poll_timeout function
> * Check for regmap read/write errors.
> * Remove memory barrier after regmap write
> * Derive memory bank offsets using stride macro variable
> * Remove debug statements from code
> * Remove the qcom_llcc_remove function
> * Use if IS_ENABLED in place of ifdef for built-in module
> * Change EXPORT_SYMBOL to EXPORT_SYMBOL_GPL
> * Remove unnecessary free functions
> * Change the variable names as per review comments
>
> Changes since v2:
> * Corrected the Makefile to fix compilation.
>
> Changes since v1:
> * Added Makefile and Kconfig.
>
> Changes since v0:
> * Removed the syscon and simple-mfd approach
> * Updated the device tree nodes to mention LLCC as a single HW block
> * Moved llcc bank offsets from device tree and handled the offset
> in the driver.
>
> ckadabi@codeaurora.org (2):
> dt-bindings: Documentation for qcom, llcc
> drivers: soc: Add LLCC driver
>
> .../devicetree/bindings/arm/msm/qcom,llcc.txt | 26 ++
> drivers/soc/qcom/Kconfig | 17 ++
> drivers/soc/qcom/Makefile | 2 +
> drivers/soc/qcom/llcc-sdm845.c | 94 ++++++
> drivers/soc/qcom/llcc-slice.c | 335
> +++++++++++++++++++++
> include/linux/soc/qcom/llcc-qcom.h | 180 +++++++++++
> 6 files changed, 654 insertions(+)
> create mode 100644
> Documentation/devicetree/bindings/arm/msm/qcom,llcc.txt
> create mode 100644 drivers/soc/qcom/llcc-sdm845.c
> create mode 100644 drivers/soc/qcom/llcc-slice.c
> create mode 100644 include/linux/soc/qcom/llcc-qcom.h

Does this spin look fine to everyone? If yes can we go ahead and merge
this?

\
 
 \ /
  Last update: 2018-06-04 18:19    [W:0.051 / U:0.640 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site