Messages in this thread | | | Date | Mon, 4 Jun 2018 08:52:38 +0200 | From | Michal Hocko <> | Subject | Re: [PATCH v7 2/2] Refactor part of the oom report in dump_header |
| |
On Sat 02-06-18 19:58:52, ufo19890607@gmail.com wrote: > From: yuzhoujian <yuzhoujian@didichuxing.com> > > The dump_header does not print the memcg's name when the system > oom happened, so users cannot locate the certain container which > contains the task that has been killed by the oom killer. > > I follow the advices of David Rientjes and Michal Hocko, and refactor > part of the oom report in a backwards compatible way. After this patch, > users can get the memcg's path from the oom report and check the certain > container more quickly.
I have earlier suggested that you split this into two parts. One to add the missing information and the later to convert it to a single printk output. Reducing the overhead from PATH_MAX to NAME_MAX is a good step but it still really begs an example why we really insist on a single printk and that should be in its own changelog.
Sorry if that was not clear previously. -- Michal Hocko SUSE Labs
| |