Messages in this thread | | | Subject | Re: [PATCH V4] mlx4_core: allocate ICM memory in page size chunks | From | Eric Dumazet <> | Date | Mon, 4 Jun 2018 06:22:26 -0700 |
| |
On 06/04/2018 06:11 AM, Michal Hocko wrote: > On Thu 31-05-18 11:10:22, Michal Hocko wrote:
> Just in case you are interested > --- > From 5010543ed6f73e4c00367801486dca8d5c63b2ce Mon Sep 17 00:00:00 2001 > From: Michal Hocko <mhocko@suse.com> > Date: Mon, 4 Jun 2018 15:07:37 +0200 > Subject: [PATCH] net: cleanup gfp mask in alloc_skb_with_frags > > alloc_skb_with_frags uses __GFP_NORETRY for non-sleeping allocations > which is just a noop and a little bit confusing. > > __GFP_NORETRY was added by ed98df3361f0 ("net: use __GFP_NORETRY for > high order allocations") to prevent from the OOM killer. Yet this was > not enough because fb05e7a89f50 ("net: don't wait for order-3 page > allocation") didn't want an excessive reclaim for non-costly orders > so it made it completely NOWAIT while it preserved __GFP_NORETRY in > place which is now redundant. > > Drop the pointless __GFP_NORETRY because this function is used as > copy&paste source for other places. > > Signed-off-by: Michal Hocko <mhocko@suse.com> > ---
Reviewed-by: Eric Dumazet <edumazet@google.com>
Thanks !
| |