lkml.org 
[lkml]   [2018]   [Jun]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    Date
    From
    Subject[PATCH] x86/microcode/intel: Ensure new microcode processor flags match with cpu's pf
    Intel spec says: 'The processor flags in the 48-byte header and the
    processor flags field associated with the extended processor signature
    structures may have multiple bits set.'

    Make sure processor flags of the new microcode intersect with current
    cpu's. Comparing with old microcode's pf can't guarantee this.

    Signed-off-by: Zhenzhong Duan <zhenzhong.duan@oracle.com>
    ---
    arch/x86/kernel/cpu/microcode/intel.c | 8 +++-----
    1 files changed, 3 insertions(+), 5 deletions(-)

    diff --git a/arch/x86/kernel/cpu/microcode/intel.c b/arch/x86/kernel/cpu/microcode/intel.c
    index 461e315..54f4014 100644
    --- a/arch/x86/kernel/cpu/microcode/intel.c
    +++ b/arch/x86/kernel/cpu/microcode/intel.c
    @@ -371,12 +371,10 @@ static int microcode_sanity_check(void *mc, int print_err)
    goto next;

    } else {
    - struct microcode_header_intel *phdr = &patch->hdr;
    -
    if (!has_newer_microcode(data,
    - phdr->sig,
    - phdr->pf,
    - phdr->rev))
    + uci->cpu_sig.sig,
    + uci->cpu_sig.pf,
    + patch->hdr.rev))
    goto next;
    }

    --
    1.7.3
    \
     
     \ /
      Last update: 2018-06-04 10:18    [W:4.260 / U:0.184 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site