Messages in this thread | | | From | Souptick Joarder <> | Date | Mon, 4 Jun 2018 10:50:35 +0530 | Subject | Re: [PATCH v2] kernel: event: core: Change return type to vm_fault_t |
| |
On Mon, May 21, 2018 at 11:55 PM, Souptick Joarder <jrdr.linux@gmail.com> wrote: > Use new return type vm_fault_t for fault handler. For > now, this is just documenting that the function returns > a VM_FAULT value rather than an errno. Once all instances > are converted, vm_fault_t will become a distinct type. > > Ref-> commit 1c8f422059ae ("mm: change return type to vm_fault_t") > > Signed-off-by: Souptick Joarder <jrdr.linux@gmail.com> > Acked-by: Peter Zijlstra (Intel) <peterz@infradead.org> > Reviewed-by: Matthew Wilcox <mawilcox@microsoft.com> > --- > v2: Updated the change log. > Acked by Peter Zijlstra. > > kernel/events/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/kernel/events/core.c b/kernel/events/core.c > index 96db9ae..d09f1c4 100644 > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -4918,11 +4918,11 @@ void perf_event_update_userpage(struct perf_event *event) > } > EXPORT_SYMBOL_GPL(perf_event_update_userpage); > > -static int perf_mmap_fault(struct vm_fault *vmf) > +static vm_fault_t perf_mmap_fault(struct vm_fault *vmf) > { > struct perf_event *event = vmf->vma->vm_file->private_data; > struct ring_buffer *rb; > - int ret = VM_FAULT_SIGBUS; > + vm_fault_t ret = VM_FAULT_SIGBUS; > > if (vmf->flags & FAULT_FLAG_MKWRITE) { > if (vmf->pgoff == 0) > -- > 1.9.1 >
Any further comment on this patch ?
| |