Messages in this thread | | | Date | Sat, 30 Jun 2018 00:26:06 +0200 | From | Lukas Wunner <> | Subject | Re: [PATCH v1 1/2] PCI: Document patch submission hints |
| |
On Fri, Jun 29, 2018 at 03:27:39PM -0500, Bjorn Helgaas wrote: > + - Wrap changelogs to fit in 80 columns when shown by "git show", which > + adds 4 spaces. I use "textwidth=75" in vim.
I guess the ideal width is subjective, I usually wrap at 72 chars because then you've got 4 blanks on either side when viewed with "git log", which I find neater than maxing out the horizontal width.
In some cases I deliberately wrap at less than 72 chars or allow 73 chars if it avoids vastly unequal widths in a paragraph. Often when I later doublecheck what you've committed, I find that you've rewrapped everything to 75 chars and the result doesn't look as neat as I wanted it to be. Not a big deal, but thought I'd mention it now that you're codifying this "rule" somewhat more formally.
Lukas
| |