Messages in this thread | | | Subject | Re: [PATCH] nvme: trace: add disk name to tracepoints | From | Sagi Grimberg <> | Date | Thu, 28 Jun 2018 17:34:07 +0300 |
| |
> Thinking more on this, not using the hw qid really limits the utility > out of using these trace events: We may not be able to match a completion > to the submission without it since cmdid alone isn't enough to match up > the two events. > > Here's an updated proposal and actually tested. I was also able to > combine admin and io submissions.
This looks good!
One thing that is missing is the controller id when we have multiple controllers/subsystems in the host like:
TP_printk("nvme%d: qid=%d, nsid=%u, cmdid=%u, flags=0x%x, meta=0x%llx, cmd=(%s %s)",
But Johannes can add it I guess.
| |