Messages in this thread | | | From | Naga Sureshkumar Relli <> | Subject | RE: [[LINUX PATCH v10] 2/4] memory: pl353: Add driver for arm pl353 static memory controller | Date | Thu, 28 Jun 2018 12:10:30 +0000 |
| |
Hi Linux,
Thanks for the review.
> -----Original Message----- > From: Linus Walleij [mailto:linus.walleij@linaro.org] > Sent: Thursday, June 28, 2018 12:19 PM > To: Naga Sureshkumar Relli <nagasure@xilinx.com> > Cc: Boris Brezillon <boris.brezillon@bootlin.com>; Richard Weinberger <richard@nod.at>; > David Woodhouse <dwmw2@infradead.org>; Brian Norris > <computersforpeace@gmail.com>; Mark Vasut <marek.vasut@gmail.com>; Florian Fainelli > <f.fainelli@gmail.com>; Markus Mayer <mmayer@broadcom.com>; Roger Quadros > <rogerq@ti.com>; Ladislav Michl <ladis@linux-mips.org>; ada@thorsis.com; > honghui.zhang@mediatek.com; Miquèl Raynal <miquel.raynal@bootlin.com>; linux- > mtd@lists.infradead.org; linux-kernel@vger.kernel.org; nagasureshkumarrelli@gmail.com; > Michal Simek <michals@xilinx.com> > Subject: Re: [[LINUX PATCH v10] 2/4] memory: pl353: Add driver for arm pl353 static > memory controller > > On Thu, Jun 21, 2018 at 8:43 AM Naga Sureshkumar Relli > <naga.sureshkumar.relli@xilinx.com> wrote: > > > Add driver for arm pl353 static memory controller. This controller is > > used in Xilinx Zynq SoC for interfacing the NAND and NOR/SRAM memory devices. > > > > Signed-off-by: Naga Sureshkumar Relli > > <naga.sureshkumar.relli@xilinx.com> > > (...) > > > +config PL353_SMC > > + tristate "ARM PL35X Static Memory Controller(SMC) driver" > > + default y > > + depends on ARM > > + depends on ARCH_ZYNQ > > depends on ARM_AMBA Ok. I will add it next version. > > > +#include <linux/platform_device.h> > > This is a PrimeCell with the ARM primecell ID registers specified, so it should not use > platform device. Thanks for pointing these drivers. Let me go through these.
> > Use <linux/amba/bus.h> > > It further needs to match on these magic values (found in > 0xfe0 etc) and use the name "apb_pclk" for the peripheral > (silicon) clock. > > See examples such as: > drivers/mmc/host/mmci.c > drivers/tty/serial/amba-pl011.c > drivers/video/fbdev/amba-clcd.c > drivers/hwtracing/coresight/* > etc for examples. > > Also see and reference the special PrimeCell DT bindings: > Documentation/devicetree/bindings/arm/primecell.txt Ok. I will go through these bindings once. > > Yours, > Linus Walleij
Thank for your review.
Regards, Naga Sureshkumar Relli.
| |