lkml.org 
[lkml]   [2018]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] objtool: Fix GCC 8 cold function processing without -freorder-functions
From
Date
Hi Peter,

On 26/06/18 17:43, Peter Zijlstra wrote:
> On Tue, Jun 26, 2018 at 05:20:45PM +0100, Allan Xavier wrote:
>> 0000000000000500 g F .text 0000000000000034 nmi_panic
>> 0000000000000528 l F .text 000000000000000c nmi_panic.cold.7
>>
>> This doesn't happen with -freorder-functions in the first example as the
>> symbols don't overlap.
>
> Urgh and I don't suppose we can 'fix' the overlap in read_symbols() ?
>

It should be fixable in read_symbols too if you don't mind sym->len not being
the same as sym->st_size in the ELF.

Is there a particular concern you're trying to address by having the logic there
instead?

Will have a look into reworking the patch in any case.

Thanks,
Allan

\
 
 \ /
  Last update: 2018-06-26 20:32    [W:2.140 / U:1.332 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site