Messages in this thread | | | From | Shakeel Butt <> | Date | Tue, 26 Jun 2018 11:00:53 -0700 | Subject | Re: [PATCH 1/2] fs: fsnotify: account fsnotify metadata to kmemcg |
| |
On Mon, Jun 25, 2018 at 10:49 PM Amir Goldstein <amir73il@gmail.com> wrote: > ... > > The verb 'unuse' takes an argument memcg and 'uses' it - too weird. > You can use 'override'/'revert' verbs like override_creds or just call > memalloc_use_memcg(old_memcg) since there is no reference taken > anyway in use_memcg and no reference released in unuse_memcg. > > Otherwise looks good to me. >
Thanks for your feedback. Just using memalloc_use_memcg(old_memcg) and ignoring the return seems more simple. I will wait for feedback from other before changing anything.
thanks, Shakeel
| |