Messages in this thread Patch in this message | | | Date | Mon, 25 Jun 2018 23:57:50 -0700 | From | tip-bot for Thomas Richter <> | Subject | [tip:perf/urgent] perf alias: Remove trailing newline when reading sysfs files |
| |
Commit-ID: ea23ac73085743a4f1682d6605fe019577c82e1e Gitweb: https://git.kernel.org/tip/ea23ac73085743a4f1682d6605fe019577c82e1e Author: Thomas Richter <tmricht@linux.ibm.com> AuthorDate: Fri, 15 Jun 2018 12:11:03 +0200 Committer: Arnaldo Carvalho de Melo <acme@redhat.com> CommitDate: Mon, 25 Jun 2018 11:59:37 -0300
perf alias: Remove trailing newline when reading sysfs files
Remove a trailing newline when reading sysfs file contents such as /sys/devices/cpum_cf/events/TX_NC_TEND. This shows when verbose option -v is used.
Output before:
tx_nc_tend -> 'cpum_cf'/'event=0x008d '/
Output after:
tx_nc_tend -> 'cpum_cf'/'event=0x8d'/
Signed-off-by: Thomas Richter <tmricht@linux.ibm.com> Reviewed-by: Hendrik Brueckner <brueckner@linux.ibm.com> Cc: Heiko Carstens <heiko.carstens@de.ibm.com> Cc: Jiri Olsa <jolsa@redhat.com> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com> Link: http://lkml.kernel.org/r/20180615101105.47047-1-tmricht@linux.ibm.com Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com> --- tools/perf/util/pmu.c | 3 +++ 1 file changed, 3 insertions(+)
diff --git a/tools/perf/util/pmu.c b/tools/perf/util/pmu.c index d2fb597c9a8c..2738fc8d200d 100644 --- a/tools/perf/util/pmu.c +++ b/tools/perf/util/pmu.c @@ -303,6 +303,9 @@ static int perf_pmu__new_alias(struct list_head *list, char *dir, char *name, FI buf[ret] = 0; + /* Remove trailing newline from sysfs file */ + rtrim(buf); + return __perf_pmu__new_alias(list, dir, name, NULL, buf, NULL, NULL, NULL, NULL, NULL, NULL); }
| |