Messages in this thread | | | Date | Tue, 26 Jun 2018 08:55:32 -0600 | From | Keith Busch <> | Subject | Re: [PATCH v4 1/2] nvme: cache struct nvme_ctrl reference to struct nvme_request |
| |
On Tue, Jun 26, 2018 at 03:51:40PM +0200, Johannes Thumshirn wrote: > @@ -652,6 +653,7 @@ blk_status_t nvme_setup_cmd(struct nvme_ns *ns, struct request *req, > } > > cmd->common.command_id = req->tag; > + nvme_req(req)->ctrl = ctrl; > if (ns) > trace_nvme_setup_nvm_cmd(req->q->id, cmd); > else
I don't think we need to do this per-io. The request coming from the controller's tagset, so we can do this just once at .init_request time, right?
| |