lkml.org 
[lkml]   [2018]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH v2 11/12] ASoC: qdsp6: q6routing: add proper error check
    Acked-by: Niklas Cassel <niklas.cassel@linaro.org>

    On Tue, Jun 26, 2018 at 10:20:15AM +0100, Srinivas Kandagatla wrote:
    > q6adm_open can return error pointer or a null in error cases.
    > Fix the return handling.
    >
    > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
    > ---
    > sound/soc/qcom/qdsp6/q6routing.c | 2 +-
    > 1 file changed, 1 insertion(+), 1 deletion(-)
    >
    > diff --git a/sound/soc/qcom/qdsp6/q6routing.c b/sound/soc/qcom/qdsp6/q6routing.c
    > index ab696bf8d1d3..c80fdbc2442e 100644
    > --- a/sound/soc/qcom/qdsp6/q6routing.c
    > +++ b/sound/soc/qcom/qdsp6/q6routing.c
    > @@ -310,7 +310,7 @@ int q6routing_stream_open(int fedai_id, int perf_mode,
    > session->channels, topology, perf_mode,
    > session->bits_per_sample, 0, 0);
    >
    > - if (!copp) {
    > + if (IS_ERR_OR_NULL(copp)) {
    > mutex_unlock(&routing_data->lock);
    > return -EINVAL;
    > }
    > --
    > 2.16.2
    >

    \
     
     \ /
      Last update: 2018-06-26 11:36    [W:2.144 / U:0.048 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site