lkml.org 
[lkml]   [2018]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] NFC: llcp: fix nfc_llcp_send_ui_frame() lockup
On (06/26/18 07:07), Dmitry Vyukov wrote:
[..]
> > #include <net/nfc/nfc.h>
> > @@ -755,7 +756,8 @@ int nfc_llcp_send_ui_frame(struct nfc_llcp_sock *sock, u8 ssap, u8 dsap,
> > pdu = nfc_alloc_send_skb(sock->dev, &sock->sk, MSG_DONTWAIT,
> > frag_len + LLCP_HEADER_SIZE, &err);
> > if (pdu == NULL) {
> > - pr_err("Could not allocate PDU\n");
> > + pr_err_ratelimited("Could not allocate PDU\n");
> > + cond_resched();
> > continue;
> > }
>
>
> But this thread is still in an infinite (unkillable?) loop? If yes, we
> are waiting for the next syzbot report ;)

The loop is still infinite, correct, but we have a preemption point now.
Sure, net people can come with a much better solution, I'll be happy to
scratch my patch.

-ss

\
 
 \ /
  Last update: 2018-06-26 07:13    [W:0.047 / U:0.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site