Messages in this thread | | | Subject | Re: s390 qemu boot failure in -next | From | Christian Borntraeger <> | Date | Tue, 26 Jun 2018 10:54:41 +0200 |
| |
On 06/26/2018 10:29 AM, Cornelia Huck wrote: [...] >>>> >>>> if (ipl->initrd) { >>>> ram_addr_t initrd_offset; >>>> >>>> would put the command line in no matter what the start address is. >>> >>> I'm for putting that one in (and backporting it to qemu-stable). It's a >>> bit worrying, though, that our ipl code is so fragile... >> >> We actually have to combine this with Thomas fix (to check for rom_ptr returning >> something sane). It seems that ipl->commandline is always there, so we have to >> check for strlen!=0 it seems.. >> >> I mean if somebody ask for "-append something" we can certainly always write something >> if there is rom/ram. > > Given that the uncompressed image is not supposed to be bootable > anymore, does it make sense to add this anyway?
I think we can drop this patch for now.
> > I'll go ahead and queue Thomas' fix, though.
yes, please
| |