Messages in this thread | | | Subject | Re: [PATCH 5/5] nvme: use __blk_mq_complete_request in timeout path | From | Sagi Grimberg <> | Date | Mon, 25 Jun 2018 21:51:07 +0300 |
| |
>> Given the amount of fixes (and fixes of fixes) we had in the timeout handler, maybe it'd be a good idea to step back and take a another look? >> >> Won't it be better to avoid disabling the device and return >> BLK_EH_RESET_TIMER if we are not aborting in the timeout handler? >> > > Yes, that would be an ideal status for nvme-pci. > But we have to depend on the timeout handler to handle the timed out request from nvme_reset_work.
Yes, so if the timeout handler is invoked from the reset, it should simply set a proper failed status and return BLK_EH_DONE.
| |