lkml.org 
[lkml]   [2018]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] rcu: Make it stop complaining about docbook function-header comment
On Mon, Jun 25, 2018 at 03:26:55PM +0900, Byungchul Park wrote:
> Running "make htmldocs" complains about the docbook function-header
> comment. It wants the "irq" parameter described which wasn't done by
> a commit 5e5ea52645b197 (rcu: Refactor rcu_{nmi,irq}_{enter,exit}()).
> So add its description of the parameter to the comment.
>
> Suggested-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
> Signed-off-by: Byungchul Park <byungchul.park@lge.com>

Very good, I will squash this into your previous patch, adding to the
commit log as suggested by Steven Rostedt.

Thanx, Paul

> ---
> kernel/rcu/tree.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/kernel/rcu/tree.c b/kernel/rcu/tree.c
> index 4ed74f1..6c5a7f0 100644
> --- a/kernel/rcu/tree.c
> +++ b/kernel/rcu/tree.c
> @@ -774,6 +774,7 @@ void rcu_user_enter(void)
>
> /**
> * rcu_nmi_exit_common - inform RCU of exit from NMI context
> + * @irq: Is this call from rcu_irq_exit?
> *
> * If we are returning from the outermost NMI handler that interrupted an
> * RCU-idle period, update rdtp->dynticks and rdtp->dynticks_nmi_nesting
> @@ -933,6 +934,7 @@ void rcu_user_exit(void)
>
> /**
> * rcu_nmi_enter_common - inform RCU of entry to NMI context
> + * @irq: Is this call from rcu_irq_enter?
> *
> * If the CPU was idle from RCU's viewpoint, update rdtp->dynticks and
> * rdtp->dynticks_nmi_nesting to let the RCU grace-period handling know
> --
> 1.9.1
>

\
 
 \ /
  Last update: 2018-06-25 17:39    [W:0.081 / U:0.028 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site