lkml.org 
[lkml]   [2018]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRE: [PATCH 1/5] net: emaclite: Use __func__ instead of hardcoded name
    Date
    > -----Original Message-----
    > From: Joe Perches [mailto:joe@perches.com]
    > Sent: Wednesday, June 20, 2018 4:08 AM
    > To: Andy Shevchenko <andy.shevchenko@gmail.com>; Radhey Shyam
    > Pandey <radheys@xilinx.com>
    > Cc: David S. Miller <davem@davemloft.net>; Andrew Lunn
    > <andrew@lunn.ch>; Michal Simek <michals@xilinx.com>; netdev
    > <netdev@vger.kernel.org>; linux-arm Mailing List <linux-arm-
    > kernel@lists.infradead.org>; Linux Kernel Mailing List <linux-
    > kernel@vger.kernel.org>
    > Subject: Re: [PATCH 1/5] net: emaclite: Use __func__ instead of hardcoded
    > name
    >
    > On Wed, 2018-06-20 at 00:36 +0300, Andy Shevchenko wrote:
    > > On Mon, Jun 18, 2018 at 2:08 PM, Radhey Shyam Pandey
    > > <radhey.shyam.pandey@xilinx.com> wrote:
    > > > Switch hardcoded function name with a reference to __func__ making
    > > > the code more maintainable. Address below checkpatch warning:
    > > >
    > > > WARNING: Prefer using '"%s...", __func__' to using
    > 'xemaclite_mdio_read',
    > > > this function's name, in a string
    > > > + "xemaclite_mdio_read(phy_id=%i, reg=%x) == %x\n",
    > > >
    > > > WARNING: Prefer using '"%s...", __func__' to using
    > 'xemaclite_mdio_write',
    > > > this function's name, in a string
    > > > + "xemaclite_mdio_write(phy_id=%i, reg=%x, val=%x)\n",
    > > >
    > >
    > > For dev_dbg() the __func__ should be completely dropped away.
    >
    > Not really the same.
    >
    > dev_dbg without CONFIG_DYNAMIC_DEBUG does not have
    > the ability to prefix __func__.
    Yes. If it's acceptable, prefer to use __func__ to support all
    configurations

    >

    \
     
     \ /
      Last update: 2018-06-25 15:48    [W:3.786 / U:0.004 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site