Messages in this thread | | | From | Petr Machata <> | Subject | Re: [PATCH RFT] net: dsa: Allow configuring CPU port VLANs | Date | Mon, 25 Jun 2018 12:13:10 +0300 |
| |
Florian Fainelli <f.fainelli@gmail.com> writes:
> if (netif_is_bridge_master(vlan->obj.orig_dev)) > - return -EOPNOTSUPP; > + info.port = dp->cpu_dp->index;
The condition above will trigger also when a VLAN is added on a member port, and there's no other port with that VLAN. In that case the VLAN comes without the BRIDGE_VLAN_INFO_BRENTRY flag. In mlxsw we have this to get the bridge VLANs:
if (netif_is_bridge_master(orig_dev)) { [...] if ((vlan->flags & BRIDGE_VLAN_INFO_BRENTRY) && [...]
This doesn't appear to be done in DSA unless I'm missing something.
Thanks, Petr
| |