lkml.org 
[lkml]   [2018]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH RFT] net: dsa: Allow configuring CPU port VLANs
Date
Florian Fainelli <f.fainelli@gmail.com> writes:

> if (netif_is_bridge_master(vlan->obj.orig_dev))
> - return -EOPNOTSUPP;
> + info.port = dp->cpu_dp->index;

The condition above will trigger also when a VLAN is added on a member
port, and there's no other port with that VLAN. In that case the VLAN
comes without the BRIDGE_VLAN_INFO_BRENTRY flag. In mlxsw we have this
to get the bridge VLANs:

if (netif_is_bridge_master(orig_dev)) {
[...]
if ((vlan->flags & BRIDGE_VLAN_INFO_BRENTRY) &&
[...]

This doesn't appear to be done in DSA unless I'm missing something.

Thanks,
Petr

\
 
 \ /
  Last update: 2018-06-25 11:14    [W:1.026 / U:0.076 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site