lkml.org 
[lkml]   [2018]   [Jun]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH V7 00/41] Intel(R) Resource Director Technology Cache Pseudo-Locking enabling
Date
Thomas Gleixner <tglx@linutronix.de> wrote:

> - Stick the struct into the local header file and not at some random place in
> the source.

Why? It's only used in that one file. There doesn't seem to be any
particular need to share it around.

> - Get rid of the fugly camel case

It's not camel case. It's the name of the option it's encoding. But if it
makes you happy...

> - Move the enablement into a separate function

Okay.

David

\
 
 \ /
  Last update: 2018-06-24 01:15    [W:0.236 / U:1.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site